Refactor MusicAccess permission checks
Reordered admin check in `MusicAccess` for efficiency by prioritizing it before role-related logic. This improves readability and minimizes unnecessary role lookups for admin users.
This commit is contained in:
1 parent
545c09d502
commit
cb47a1622f
1 file changed
+2
-4
@@ -32,14 +32,12 @@ public final class MusicAccess {
|
||||
}
|
||||
|
||||
Guild guild = member.getGuild();
|
||||
|
||||
String roleDb = guildService.getGuildSettingService().getOrDefault(GSettings.MUSIC_ROLE);
|
||||
|
||||
if (roleDb != null && !roleDb.isEmpty()) {
|
||||
if (UserFunction.isAdmin(member)) {
|
||||
return true;
|
||||
}
|
||||
|
||||
String roleDb = guildService.getGuildSettingService().getOrDefault(GSettings.MUSIC_ROLE);
|
||||
if (roleDb != null && !roleDb.isEmpty()) {
|
||||
Role neededRole = guild.getRoleById(roleDb);
|
||||
if (neededRole == null) {
|
||||
// Role doesn't exist on guild anymore, remove from db
|
||||
|
||||
Reference in new issue
Block a user