Refactor MusicAccess permission checks

Reordered admin check in `MusicAccess` for efficiency by prioritizing it before role-related logic. This improves readability and minimizes unnecessary role lookups for admin users.
This commit is contained in:
anthorob committed 2026-10-14 08:32:32 -04:00
1 parent 545c09d502
commit cb47a1622f
1 file changed
+3 -5
@@ -32,14 +32,12 @@ public final class MusicAccess {
} }
Guild guild = member.getGuild(); Guild guild = member.getGuild();
if (UserFunction.isAdmin(member)) {
return true;
}
String roleDb = guildService.getGuildSettingService().getOrDefault(GSettings.MUSIC_ROLE); String roleDb = guildService.getGuildSettingService().getOrDefault(GSettings.MUSIC_ROLE);
if (roleDb != null && !roleDb.isEmpty()) { if (roleDb != null && !roleDb.isEmpty()) {
if (UserFunction.isAdmin(member)) {
return true;
}
Role neededRole = guild.getRoleById(roleDb); Role neededRole = guild.getRoleById(roleDb);
if (neededRole == null) { if (neededRole == null) {
// Role doesn't exist on guild anymore, remove from db // Role doesn't exist on guild anymore, remove from db