From 861b3f90e76e8744697e4be1d814ec3973c536b4 Mon Sep 17 00:00:00 2001 From: anthorob Date: Fri, 9 Oct 2026 03:16:09 -0400 Subject: [PATCH] Refine VoteSkipService warnings and remove redundant announce calls Updated the warning message in `VoteSkipService` to provide more precise feedback when attempting to vote on an empty queue. Removed an unnecessary `announce` call in `MusicRoutes`'s `resumePlayback` for cleaner and more concise code execution. --- .../java/me/bobert/netneutrality/http/server/MusicRoutes.java | 3 +-- .../java/me/bobert/netneutrality/music/VoteSkipService.java | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/me/bobert/netneutrality/http/server/MusicRoutes.java b/src/main/java/me/bobert/netneutrality/http/server/MusicRoutes.java index 01e21cb..6ed995f 100644 --- a/src/main/java/me/bobert/netneutrality/http/server/MusicRoutes.java +++ b/src/main/java/me/bobert/netneutrality/http/server/MusicRoutes.java @@ -221,7 +221,6 @@ public final class MusicRoutes { private static void resumePlayback(Supplier jdaSupplier, MusicService musicService, Context ctx) { MusicManager manager = manager(jdaSupplier, musicService, ctx); manager.unpauseTrack(); - announce(manager, "Resuming current track"); ctx.json(Map.of("status", "ok", "message", "Resuming current track")); } @@ -347,7 +346,7 @@ public final class MusicRoutes { MusicManager manager = musicService.get(guild); String userId = ctx.pathParam("userId"); - CacheOrFetch.resolve( + CacheOrFetch.resolve( ctx, () -> guild.getMemberById(userId), () -> guild.retrieveMemberById(userId), diff --git a/src/main/java/me/bobert/netneutrality/music/VoteSkipService.java b/src/main/java/me/bobert/netneutrality/music/VoteSkipService.java index a102fae..04bf534 100644 --- a/src/main/java/me/bobert/netneutrality/music/VoteSkipService.java +++ b/src/main/java/me/bobert/netneutrality/music/VoteSkipService.java @@ -56,7 +56,7 @@ public class VoteSkipService { TrackInfo info = queueManager.peekHeadOfQueue(); if (info == null) { - return QueueActionResult.warn("Queue is empty"); + return QueueActionResult.warn("The queue is empty, you can't cast a vote on an empty queue"); } // Minus the bot itself